Ensure platform_variant is set for S3 artifact uploads#304
Merged
NotTheEvilOne merged 1 commit intomainfrom Feb 4, 2026
Merged
Ensure platform_variant is set for S3 artifact uploads#304NotTheEvilOne merged 1 commit intomainfrom
platform_variant is set for S3 artifact uploads#304NotTheEvilOne merged 1 commit intomainfrom
Conversation
Fixes: #303 Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
NotTheEvilOne
force-pushed
the
fix/missing-platform-variant-303
branch
from
f3b4a43 to
5024d20
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 91.44% 91.50% +0.05%
==========================================
Files 42 42
Lines 2092 2095 +3
==========================================
+ Hits 1913 1917 +4
+ Misses 179 178 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nkraetzschmar
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a regression related to S3 artifact metadata not containing
platform_variant.Which issue(s) this PR fixes:
Fixes #303